[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GNU Autoconf 2.67] testsuite: 199 246 failed

From: Eric Blake
Subject: Re: [GNU Autoconf 2.67] testsuite: 199 246 failed
Date: Wed, 04 Aug 2010 15:09:34 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.1.1

On 08/04/2010 03:04 PM, Bob Friesenhahn wrote:
> On Wed, 4 Aug 2010, Ralf Wildenhues wrote:
>> This is a testsuite bug: it should not trip over a quoting bug in some
>> third-party macro file you have installed.  OK to fix Autoconf as below?
>> But please do fix that xmms.m4 file to not have underquoted macros.
> I do see some quoting in the xmms macro but it makes me bleary-eyed and
> I hesitate to try fixing it without breaking it.  If it really causes
> problems, I could simply delete the file.

It is probably doing:

mess of code)

when it should be doing:

mess of code)

In other words, it is likely that the only missing quoting that
autoreconf is warning about is that of the first argument - while you
are probably right that the rest of the macro is probably not very
robust, you can at least rest assured that quoting errors in the rest of
the macro will not impact anyone except those who actually use the
macro.  Only the quoting error on the first argument can affect

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]