bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: prompt with \[ \] corrupted by vi history search


From: Eric Blake
Subject: Re: prompt with \[ \] corrupted by vi history search
Date: Wed, 08 Feb 2006 05:57:27 -0700
User-agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Mike Stroyan on 2/3/2006 12:16 PM:
> Description:
>       The prompt is corrupted when using the vi Esc/ history search.
>       This happens when the prompt contains non-printing characters
>       marked by the \[ \] delimiters.
> 
> Fix:
>       The best fix seems to be in _rl_make_prompt_for_search in 
>       bash/lib/readline/display.c
> 
>       Everything behaves better if _rl_make_prompt_for_search just uses the
>       unexpanded rl_prompt string for composing its result.  Here is a patch
>       that comments out the troublesome code.

My only concern is whether this patch also affects {non-,}incremental
searches in emacs mode.  But it sure solves the display bugs of doing
non-incremental searches in vi mode.  Thanks for the patch.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFD6eq384KuGfSFAYARAkmQAKDPCFFZ3JPbP7++QXC5cdwPMLgzCwCcCki5
nW6wa5K/KEQ94R6YNrUs84s=
=NPWW
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]