[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] colored filename completion

From: Raphaël Droz
Subject: Re: [patch] colored filename completion
Date: Sun, 26 Jun 2011 17:42:31 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Sat, Jun 25, 2011 at 11:56:25PM +0200, Raphaël Droz wrote:
> On Tue, May 31, 2011 at 01:32:44AM +0200, Raphaël wrote:
> > Hi,
> > 
> > I finished 6 patches which add color to filename completions in
> > readline.
> Those who tried the patch may have noticed (at least) two bugs:
> * completion of command names was annoying: every match was considered as
> a missing-file
> It is (partly) fixed with the attached 
> "dont-bug-command-name-completion.patch"
> The lowest common denominator calculation is skipped.
> three main drawbacks stays after this patch:
> - duplication is not correct:
> - aliases, functions, ... and any too "abstract" command name is still
> considered as an "missing file". (The goal of the patch was just to make
> the "binary in $PATH"-case not that "abstract").
> - in the end (print_filename()) priority is given to the filesystem so:

Attached is an updated version of "dont-bug-command-name-completion.patch".

Deduplication is now correct by adding a new qsort() comparison routine
which takes care of striping the directory part of the path.
Sort of matches is now correct too.

The two last drawbacks above are not solved (but are minor).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]