Re: bash-4.2, crosscompiling and job control compile failure

[bigbigboy]

On Sep 15, 9:20 am, Chet Ramey <chet.ra...@case.edu> wrote:
> On 9/14/11 4:57 PM, Maciej Grela wrote:
>
> > In which tarball will your fix be released ? I don't understand the
> > code flow between the tarballs and git on savannah, the git repo
> > contains only imports from tarballs until 4.0, and the newest tarball
> > is 4.2.
>
> It will come out as part of bash-4.3.  It may be released as a patch to
> bash-4.2, but, based on the number of reports, it's not a high-priority
> issue.
>
> Chet
>
> --
> ``The lyf so short, the craft so long to lerne.'' - Chaucer
>                  ``Ars longa, vita brevis'' - Hippocrates
> Chet Ramey, ITS, CWRU    c...@case.edu    http://cnswww.cns.cwru.edu/~chet/

Chet,
I tried to cross compile with arm toolchain.
Would you please have a check if the following patch is proper?
Thanks!

diff --git a/execute_cmd.c b/execute_cmd.c
index 485b0c7..20be69a 100644
--- a/execute_cmd.c
+++ b/execute_cmd.c
@@ -2202,7 +2202,11 @@ execute_pipeline (command, asynchronous,
pipe_in, pipe_out, fds_to_close)
   /* If the `lastpipe' option is set with shopt, and job control is
not
      enabled, execute the last element of non-async pipelines in the
      current shell environment. */
+#if defined (JOB_CONTROL)
   if (lastpipe_opt && job_control == 0 && asynchronous == 0 &&
pipe_out == NO_PIPE && prev > 0)
+#else
+  if (lastpipe_opt && asynchronous == 0 && pipe_out == NO_PIPE &&
prev > 0)
+#endif
     {
       lstdin = move_to_high_fd (0, 0, 255);
       if (lstdin > 0)