[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
small fix for lib/sh/snprintf.c
From: |
Petr Sumbera |
Subject: |
small fix for lib/sh/snprintf.c |
Date: |
Thu, 12 Apr 2012 18:25:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9.2.13) Gecko/20110117 Lightning/1.0b2 Thunderbird/3.1.7 |
Hi,
we are running Bash 3.2.38 on Solaris 10 where asprintf() isn't
available. Thus code in snprintf.c is used.
There is a problem with following command:
bash -c 'printf "x%10.0fx\n" 123'
x0000000123x
Where correct output should be:
x 123x
It seems that '0' after '.' enables zero padding. Please see proposed
patch bellow:
--- bash-3.2.48/lib/sh/snprintf.c Tue Dec 12 12:10:18 2006
+++ bash-3.2.48/lib/sh/snprintf.c Thu Apr 12 08:55:44 2012
@@ -1277,6 +1277,8 @@
data->flags |= PF_ALTFORM;
continue;
case '0':
+ if (data->flags & PF_DOT)
+ continue;
data->flags |= PF_ZEROPAD;
data->pad = '0';
continue;
The same code seems to be also in Bash 4.1 so I guess the problem is
still there.
Any comments?
Thanks,
Petr
- small fix for lib/sh/snprintf.c,
Petr Sumbera <=