[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: devel branch build failure
From: |
Eric Blake |
Subject: |
Re: devel branch build failure |
Date: |
Wed, 12 Dec 2012 09:32:33 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 12/12/2012 08:57 AM, Steven W. Orr wrote:
>>
>
> Hold on! A make clean should delete all derived files. y.tab.[ch] are
> derived and should be present in a clean sandbox.
Rather, 'make clean' should delete all derived files not present in a
tarball, and 'make maintainer-clean' should delete ALL derived files
that can be rebuilt but where the rebuild may require tools that aren't
required for the normal user building from a tarball.
Building from git is different than building from a tarball, and I argue
that there are derived files (such as y.tab.[ch]) that must exist in the
tarball but can be safe to omit from git, if we are willing to assume
that developers building from git can be assumed to have the maintainer
tools. Treating git like building from a tarball is not necessarily
worth the headache.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature