bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bash-4.3 Official Patch 30


From: Chet Ramey
Subject: Re: Bash-4.3 Official Patch 30
Date: Tue, 07 Oct 2014 11:53:18 -0400
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

On 10/6/14, 6:16 PM, John E. Malmberg wrote:

>>> Do you mean return ""; ?
>>
>> Yes, good catch.  It doesn't make a difference: clang and gcc both accept
>> it as written and it behaves as desired.  However, I'll change it for the
>> next version.
> 
> Changing it to return 0 instead of '\0' would probably be more clear.
> No need to return a pointer to a static empty string.

It depends on how you want the function to work.  It is nice to
differentiate between the cases where there is no shell input line
at all, where the index is just wrong, and the actual current input
pointer.  A "" indicates the second case better than a 0, though it's
not perfect.

Chet


-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU    address@hidden    http://cnswww.cns.cwru.edu/~chet/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]