bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Parse error with consecutive case statements inside $()


From: Chet Ramey
Subject: Re: Parse error with consecutive case statements inside $()
Date: Fri, 1 Apr 2016 08:16:46 -0400
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.7.1

On 4/1/16 4:21 AM, Piotr Grzybowski wrote:
> Hello!
> 
>  I firmly believe that the attached patch fixes the problem at hand; what
> it breaks I have no idea. Kindly requesting a review.

It breaks the test suite.

It tries to do a little bit too much: it should not add the character to
the return buffer and go on to the next one if later code needs to do
something with it (e.g., if it's a `)').

Here's a version of the patch that does the trick.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU    address@hidden    http://cnswww.cns.cwru.edu/~chet/

Attachment: comsub-case.patch
Description: Source code patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]