bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Various improvements to tests/run-all


From: Chet Ramey
Subject: Re: Various improvements to tests/run-all
Date: Thu, 1 Dec 2016 16:12:24 -0800
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.5.0

On 12/1/16 3:21 PM, Vladimir Marek wrote:
> Hi,
> 
> I am attaching patch against tests/run-all with the hope that the
> changes can be accepted upstream. The patch should be self explanatory.
> For completeness here are the errors I saw before I erased SHELLOPTS
> variable

I can see doing this.  From the error messages in your message, it seems
like you enable posix mode via SHELLOPTS.  The tests definitely don't
expect to be run in posix mode.

As for your other suggestions, bash-4.4 doesn't use /tmp/xx; that's a
remnant from previous versions.  bash-4.4 sets, exports, and uses
$BASH_TSTOUT.  Also, sh is just used to run each test harness (e.g.,
run-redir).  All of those scripts run the actual test scripts using
$THIS_SH, so there's no real gain to using $THIS_SH there.

Chet
-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    address@hidden    http://cnswww.cns.cwru.edu/~chet/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]