bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

valid kernel patch? using -e to catch errors?


From: L A Walsh
Subject: valid kernel patch? using -e to catch errors?
Date: Mon, 29 Jul 2019 00:16:56 -0700
User-agent: Thunderbird

I wonder if this patch that went into the linux kernel, 5.2.3, will do what
they think it will since posix changed the meaning.

If not, maybe Greg should go over and explain it to them!

commit df324bab425f70bf2a1d11f5880c88940b7e403d
Author: Masahiro Yamada <address@hidden>
Date:   Tue Jun 25 16:26:22 2019 +0900

    x86/build: Add 'set -e' to mkcapflags.sh to delete broken capflags.c
    
    [ Upstream commit bc53d3d777f81385c1bb08b07bd1c06450ecc2c1 ]
    
    Without 'set -e', shell scripts continue running even after any
    error occurs. The missed 'set -e' is a typical bug in shell scripting.
    
    For example, when a disk space shortage occurs while this script is
    running, it actually ends up with generating a truncated capflags.c.
    
    Yet, mkcapflags.sh continues running and exits with 0. So, the build
    system assumes it has succeeded.
    
    It will not be re-generated in the next invocation of Make since its
    timestamp is newer than that of any of the source files.
    
    Add 'set -e' so that any error in this script is caught and propagated
    to the build system.
    
    Since 9c2af1c7377a ("kbuild: add .DELETE_ON_ERROR special target"),
    make automatically deletes the target on any failure. So, the broken
    capflags.c will be deleted automatically.
    
    Signed-off-by: Masahiro Yamada <address@hidden>
    Signed-off-by: Thomas Gleixner <address@hidden>
    Cc: "H. Peter Anvin" <address@hidden>
    Cc: Borislav Petkov <address@hidden>
    Link: https://lkml.kernel.org/r/address@hidden
    Signed-off-by: Sasha Levin <address@hidden>





reply via email to

[Prev in Thread] Current Thread [Next in Thread]