bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bind -X shows inactive bindings (bindings removed using bind -r)


From: Chet Ramey
Subject: Re: bind -X shows inactive bindings (bindings removed using bind -r)
Date: Fri, 13 Dec 2019 14:25:36 -0500
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.3.0

On 12/12/19 8:04 AM, Koichi Murase wrote:

I also would like to see this problem fixed.  In this February, I
actually posted to this mailing list a patch fixing this problem (with
another patch):

https://lists.gnu.org/archive/html/bug-bash/2019-02/msg00038.html

Although the first patch was applied to the devel branch, the second
one which fixes this problem seems not to have been reviewed yet.  I
updated the patch to fit the current devel branch.  I attach the
updated patch.  Here is the description quoted from the mail:

I declined to apply this patch because, as you observe, it uses private
readline APIs. Bash doesn't do that. Nor did I think it was the right
approach to the problem.

Note that in the attached patch the functions in Readline library,
`_rl_get_keyname' and `_rl_untranslate_macro_value', were made public
and used from Bash codes.  I think it is worth to make them a part of
public interface of Readline library.

I'm not convinced.

I appreciate the reminder, though. This was still on my list of issues
to look at, so I took a look.

It takes maybe a dozen lines of code, and no modifications to readline,
to solve the problem with `bind -r'. There are a couple of other remaining
issues, but that one was easy.

Chet

--
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    address@hidden    http://tiswww.cwru.edu/~chet/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]