|
From: | Daniel Colascione |
Subject: | Re: [PATCH] Add active mark, face support; activate mark on paste |
Date: | Sun, 12 Apr 2020 20:04:03 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 4/12/20 6:23 PM, Chet Ramey wrote:
On 4/12/20 2:15 PM, gentoo_eshoes@tutanota.com wrote:There is one more/different 'face' issue: if I paste a line and then press Enter (as opposed to any alphanumeric key or arrow keys) then the highlight remains(highlighted), possibly because the ^M is echoed and thus moves the cursor one line up(?) before the highlight is attempted to be removed. But I'm just guessing.Unsurprising. The highlights are added and removed in readline's redisplay. Once you enter newline (or any key bound to accept-line), readline returns the line immediately without any redisplay, so the line remains as is.
Is that a regression relative to my original patch? I could have sworn I made command submission deactivate the mark and redisplay, but maybe I'm recalling incorrectly. In any case, isn't that the right thing to do?
FWIW, for debugging the kinds of issues we're discussing here, rr(1) is _incredibly_ helpful.
[Prev in Thread] | Current Thread | [Next in Thread] |