[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Bash 5.1: accept loadable build fix

From: Marc Aurèle La France
Subject: Bash 5.1: accept loadable build fix
Date: Mon, 1 Feb 2021 16:16:37 -0700 (MST)
User-agent: Alpine 2.20 (LNX 67 2015-01-07)

typemax.h states it should be included after config.h, limits.h, stdint.h, 
and inttypes.h.  But, on my system (with glibc 2.32), accept.c ends up 
including <limits.h> after typemax.h, via the sequence ...

accept.c -> loadables.h -> builtins.h -> general.h -> <limits.h>

... resulting in a compile failure.

Below is a suggested fix.  While there, remove an unused variable.

Please Reply-To-All.



--- bash-5.1/examples/loadables/accept.c
+++ devel-5.1/examples/loadables/accept.c
@@ -30,6 +30,7 @@
 #include "bashtypes.h"
 #include <errno.h>
 #include <time.h>
+#include <limits.h>
 #include "typemax.h"

 #include <sys/socket.h>
@@ -44,7 +45,6 @@ int
 accept_builtin (list)
      WORD_LIST *list;
-  WORD_LIST *l;
   SHELL_VAR *v;
   intmax_t iport;
   int opt;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]