Re: address@hidden: Bug#247346: Patch for the bug]

[Nick Clifton]

Hi Hakan,

> The attached patch (when dropped into a debian/patches folder for 
> binutils-avr) provides a new flag to avr-as "--allow-dollars", which 
> overrides the default settings to always allow dollars in function 
> names. Behaviour without this flag is unchanged from standard avr-as.

It seems to me that this is the wrong way to fix this problem.  It is 
creating a new generic command line switch for GAS which is used to fix 
a problem with the AVR port.  I would be much happier with a patch that 
only modifies AVR specific files (ie gas/config/tc-avr.c).  A generic 
patch seems to me like unnecessary feature bloat.

Cheers
  Nick