[Bug binutils/1486] DISASSEMBLER_NEEDS_RELOCS doesn't work correctly

[nickc at redhat dot com]

------- Additional Comments From nickc at redhat dot com  2005-10-19 17:06 
-------
Subject: Re:  New:  DISASSEMBLER_NEEDS_RELOCS doesn't work
 correctly

Hi H.J.

> added DISASSEMBLER_NEEDS_RELOCS based in the enabled targets at configure
> time. It has several problems:
> 
> 1. It isn't enabled for --enable-targets=all.

True, although I am not sure if this is a serious problem.


> 2. Objdump for i386 now has 2 different assemblers, depending on if the
> enabled target defines DISASSEMBLER_NEEDS_RELOCS or not.

This point has me confused.  Do you mean 2 different *assemblers* or 2 
different *disassemblers* ?


> 3. The i386 assembler works incorrectly when ARM is enabled since the 
> assembler
> is different due to DISASSEMBLER_NEEDS_RELOCS.

Just how common is it to build such a toolchain I wonder.  Most people 
would only build a single-targeted toolchain not a multiply targeted 
toolchain like the one you mention above.


 > which leads to "make check" failure on Linux/x86 when
 > --enable-targets=arm-linux is used.

Which failure is this ?


> I think DISASSEMBLER_NEEDS_RELOCS should be fixed and it should be enabled
> at run-time depending on targets, if needed, instead of configure time.

Well this is a reasonable request and should be too hard to do.  The 
patch ought to be sure that relocs are not read in unnecessarily and 
that the absence of relocs does not prevent disassembly, but otherwise 
it should be quite straightforward.  Please feel free to submit a 
suitable patch.

Cheers
   Nick


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=1486

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.