[Bug binutils/2454] New: incorrect syntax in avr disassembly

[hochstein at algo dot informatik dot tu-darmstadt dot de]

The disassembly for call and jmp looks like this:

     43a:       0e 94 7e 0e     call    0x1cfc <__divmodhi4>

This causes problems since the "<identifier>" part is not correct assembler
syntax. It should read like this:

     43a:       0e 94 7e 0e     call    0x1cfc  ; <__divmodhi4>

The following patch solves the problem for me:

diff -ubr binutils-2.16/opcodes/avr-dis.c binutils-2.16-patched/opcodes/avr-dis.
--- binutils-2.16/opcodes/avr-dis.c     Thu Mar  3 12:49:47 2005
+++ binutils-2.16-patched/opcodes/avr-dis.c     Mon Mar 13 15:54:06 2006
@@ -142,7 +142,8 @@
     case 'h':
       *sym = 1;
       *sym_addr = ((((insn & 1) | ((insn & 0x1f0) >> 3)) << 16) | insn2) * 2;
-      sprintf (buf, "0x");
+      sprintf (buf, "0x%x", *sym_addr);
+      sprintf (comment, "0x");
       break;
       
     case 'L':

-----

-- 
           Summary: incorrect syntax in avr disassembly
           Product: binutils
           Version: 2.16
            Status: NEW
          Severity: normal
          Priority: P1
         Component: binutils
        AssignedTo: unassigned at sources dot redhat dot com
        ReportedBy: hochstein at algo dot informatik dot tu-darmstadt dot de
                CC: bug-binutils at gnu dot org
 GCC build triplet: i686-pc-linux
  GCC host triplet: avr
GCC target triplet: avr


http://sourceware.org/bugzilla/show_bug.cgi?id=2454

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.