[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [incomplete patch] Get objdump to report exception tables for ARM/SH
Re: [incomplete patch] Get objdump to report exception tables for ARM/SH4 correctly
Mon, 14 Apr 2008 15:39:28 +0100
Thunderbird 18.104.22.168 (X11/20080213)
(Sorry about the delay in replying, I am a bit snowed under at the
One of the earlier suggestions was for the default print_pdata to be
used when the new field is NULL. This is how I implemented it.
Doh, yes I should have realized that.
I don't think I understand. If it's a static function in peXXigen.c then
I can't use it in e.g. pe-arm-wince.c to initialise the structure.
Also right now there are two functions. The original one, and one to
handle the ARM and SH4 compressed pdata cases. Putting them together in
one file is fine by me, but putting them in a source file that can be
included more than once seems wrong. This would, I think, apply to both
the function I'm adding and to the default one. Should they not be in
another source file (one that doesn't get the XX treatment) so they get
included just once ?
Yes of course. (Sorry my brain was not firing on all cylinders that day).
So I still think I need a source file that doesn't get the XX treatment
to put both functions in as non-static functions. But I am probably
overlooking something, I'm new to the binutils source.
No, I think that you are right.