[Bug gas/7026] New: ARM target wont build, error: format not a string literal and no format arguments

[pwjansen at yahoo dot com]

building arm-elf target,

Configured with,

 ../binutils-2.19/configure --target=arm-elf --prefix=/home/peter/arm/install
--enable-interwork --enable-multilib --disable-nls --disable-shared
--disable-threads --with-gcc --with-gnu-as --with-gnu-ld


Make stopps with the following message,

gcc -DHAVE_CONFIG_H -I. -I../../binutils-2.19/gas -I. -I.
-I../../binutils-2.19/gas -I../bfd -I../../binutils-2.19/gas/config
-I../../binutils-2.19/gas/../include -I../../binutils-2.19/gas/..
-I../../binutils-2.19/gas/../bfd
-DLOCALEDIR="\"/home/peter/arm/install/share/locale\""   -W -Wall
-Wstrict-prototypes -Wmissing-prototypes -Werror -g -O2 -c
../../binutils-2.19/gas/config/tc-arm.c
cc1: warnings being treated as errors
../../binutils-2.19/gas/config/tc-arm.c: In function ‘s_arm_unwind_save_mmxwr’:
../../binutils-2.19/gas/config/tc-arm.c:3459: error: format not a string literal
and no format arguments
../../binutils-2.19/gas/config/tc-arm.c:3473: error: format not a string literal
and no format arguments
../../binutils-2.19/gas/config/tc-arm.c: In function ‘s_arm_unwind_save_mmxwcg’:
../../binutils-2.19/gas/config/tc-arm.c:3591: error: format not a string literal
and no format arguments
../../binutils-2.19/gas/config/tc-arm.c:3606: error: format not a string literal
and no format arguments
../../binutils-2.19/gas/config/tc-arm.c: In function ‘s_arm_unwind_movsp’:
../../binutils-2.19/gas/config/tc-arm.c:3712: error: format not a string literal
and no format arguments
make[4]: *** [tc-arm.o] Error 1

The fix is quite easy,

--- binutils-2.19/gas/config/tc-arm.c   2008-08-13 09:39:30.000000000 +1000
+++ binutils-2.19-arm/gas/config/tc-arm.c       2008-11-12 19:51:08.000000000 
+1100
@@ -3456,7 +3456,7 @@
 
       if (reg == FAIL)
        {
-         as_bad (_(reg_expected_msgs[REG_TYPE_MMXWR]));
+         as_bad ("%s", _(reg_expected_msgs[REG_TYPE_MMXWR]));
          goto error;
        }
 
@@ -3470,7 +3470,7 @@
          hi_reg = arm_reg_parse (&input_line_pointer, REG_TYPE_MMXWR);
          if (hi_reg == FAIL)
            {
-             as_bad (_(reg_expected_msgs[REG_TYPE_MMXWR]));
+             as_bad ("%s", _(reg_expected_msgs[REG_TYPE_MMXWR]));
              goto error;
            }
          else if (reg >= hi_reg)
@@ -3588,7 +3588,7 @@
 
       if (reg == FAIL)
        {
-         as_bad (_(reg_expected_msgs[REG_TYPE_MMXWCG]));
+         as_bad ("%s", _(reg_expected_msgs[REG_TYPE_MMXWCG]));
          goto error;
        }
 
@@ -3603,7 +3603,7 @@
          hi_reg = arm_reg_parse (&input_line_pointer, REG_TYPE_MMXWCG);
          if (hi_reg == FAIL)
            {
-             as_bad (_(reg_expected_msgs[REG_TYPE_MMXWCG]));
+             as_bad ("%s", _(reg_expected_msgs[REG_TYPE_MMXWCG]));
              goto error;
            }
          else if (reg >= hi_reg)
@@ -3709,7 +3709,7 @@
   reg = arm_reg_parse (&input_line_pointer, REG_TYPE_RN);
   if (reg == FAIL)
     {
-      as_bad (_(reg_expected_msgs[REG_TYPE_RN]));
+      as_bad ("%s", _(reg_expected_msgs[REG_TYPE_RN]));
       ignore_rest_of_line ();
       return;
     }

-- 
           Summary: ARM target wont build,  error: format not a string
                    literal and no format arguments
           Product: binutils
           Version: 2.19
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gas
        AssignedTo: unassigned at sources dot redhat dot com
        ReportedBy: pwjansen at yahoo dot com
                CC: bug-binutils at gnu dot org
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: arm-unknown-elf


http://sourceware.org/bugzilla/show_bug.cgi?id=7026

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.