[Bug binutils/13051] windres fails on reading VERSIONINFO with multiple language BLOCKS

[nickc at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13051

Nick Clifton <nickc at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING
                 CC|                            |nickc at redhat dot com

--- Comment #3 from Nick Clifton <nickc at redhat dot com> 2011-08-12 11:14:35 
UTC ---
Hi Chris,

  Thanks for reporting this problem, and for providing a patch to fix it. 
Unfortunately as the patch stands I cannot accept it.  There is one main reason
for this:

  1.  The patch is sufficiently large that it cannot be treated as "obvious",
which means that we (the FSF) need a copyright assignment on file from you in
order to make use of the patch.

      I know that in your ReadMe.txt file you say that "This source code is
free and you can use it without any restriction", but that does not make it
clear that you are referring to the patch rather than the binutils sources
(which do have some restrictions on their use).  But even if it was clear that
you meant the patch files themselves it would not matter.  We need the
copyright assignment so that we can incorporate the patches into the binutils
sources and then cover the patches with the GPLv3.

    You can start the process of assigning the copyright by filing in the form
that you will find here:
http://web.cvs.savannah.gnu.org/viewvc/gnulib/Copyright/request-assign.changes?root=gnulib&view=log


Ideally I would also like to see some changes and additions to the patch:

  2. Lots of the changes are just adjustments in whitespace or the addition of
ctrl-M characters.  It would be nice to get rid of these.

  3. There is no ChangeLog entry describing what the patch does.

  4. The test of the fixed behaviour ought to be added to the binutils
testsuite.  (See binutils/testsuite/binutils-all/windres/version.{rc|rsd} as an
example of how to do this).

Cheers
  Nick Clifton

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.