[Bug binutils/14243] software that includes bfd.h fails to build with "#error config.h must be included before this header"

[amodra at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14243

Alan Modra <amodra at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |amodra at gmail dot com
         Resolution|                            |WONTFIX

--- Comment #1 from Alan Modra <amodra at gmail dot com> 2012-06-15 00:33:54 
UTC ---
This is a correctness issue.  bfd.h and the headers that bfd.h #include test at
least one HAVE_* macro.  So you need to include the file that defines those
HAVE_* macros before bfd.h.  You may argue that the use of HAVE_STRINGSIZE will
never affect any host that builds oprofile.  While that may be true, it's still
a correctness issue.  Future versions of bfd.h may test other HAVE_* macros.

This isn't about requiring any of the various binutils config.h files, but
rather *an* autoconf generated config.h.  It's completely irrelevant that
opagent.c itself does not need config.h.  opagent.c *and its headers* needs
config.h.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.