[Bug binutils/14243] software that includes bfd.h fails to build with "#error config.h must be included before this header"

[amodra at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14243

--- Comment #2 from Alan Modra <amodra at gmail dot com> 2012-06-15 02:14:04 
UTC ---
A further comment.  I see HAVE_STRINGIZE is obsolescent according to the
autoconf docs.  So my argument for config.h being included before the current
version of bfd.h isn't really that strong.  However, it is a really good idea
to always include config.h (or sysdep.h or alloca-conf.h that include config.h)
before any other files, including system headers.  See bug #13558.

Beside all that, I can't see the binutils project reverting this change.  Yes,
it causes some initial pain (and I grumbled about the change myself), but
overall the change is a good one.  If you (oprofile project) want to insulate
yourself from a change like this one, then you really should be distributing
your own copy of bfd along with oprofile sources.  That would allow you to
resolve these issues at your leisure.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.