[Bug gas/14315] Inconsistent .weak and .comm directives

[hjl.tools at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14315

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2012-06-30 00:34:13 
UTC ---
This works for me:

diff --git a/gas/config/obj-elf.c b/gas/config/obj-elf.c
index f9da1ee..08d337a 100644
--- a/gas/config/obj-elf.c
+++ b/gas/config/obj-elf.c
@@ -350,6 +350,11 @@ elf_common_parse (int ignore ATTRIBUTE_UNUSED, symbolS
*symbolP, addressT size)
     }
     }

+  /* Double check weak symbols.  */
+  if (S_IS_WEAK (symbolP))
+    as_bad (_("symbol `%s' can not be both weak and common"),
+        S_GET_NAME (symbolP));
+
   if (is_local)
     {
       bss_alloc (symbolP, size, align);

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.