[Bug binutils/12549] --as-needed should ignore weak references

[ossman at cendio dot se]

http://sourceware.org/bugzilla/show_bug.cgi?id=12549

--- Comment #2 from Pierre Ossman <ossman at cendio dot se> 2013-01-09 15:34:55 
UTC ---
Created attachment 6806
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6806
binutils-2.21-as-needed-cleanup.patch

This patch exposed/cause another problem; the "as needed" cleanup doesn't
restore the strtab properly. This resulted in an assertion later on (see bug
14862).

The problem was that it iterates over the symbols, checking which have added
new entries in the strtab. So far so good, but it did it *after* it had
restored the symbol table. This meant it would overlook any new symbols
created, e.g. when a versioned symbol is added.

The attached patch does the strtab cleanup before restoring the symbol table,
which avoids this issue.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.