[Bug gold/16010] New: Incorrect dependency in gold/testsuite

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16010

            Bug ID: 16010
           Summary: Incorrect dependency in gold/testsuite
           Product: binutils
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gold
          Assignee: ian at airs dot com
          Reporter: hjl.tools at gmail dot com
                CC: ccoutant at google dot com

gold/testsuite/Makefile.am has the default DEPENDENCIES and LDADD:

DEPENDENCIES = \
        libgoldtest.a ../libgold.a ../../libiberty/libiberty.a $(LIBINTL_DEP)
LDADD = libgoldtest.a ../libgold.a ../../libiberty/libiberty.a $(LIBINTL) \
        $(THREADSLIB) $(LIBDL)

But some tests define DEPENDENCIES without LDADD:

check_PROGRAMS += large_symbol_alignment
large_symbol_alignment_SOURCES = large_symbol_alignment.cc
large_symbol_alignment_DEPENDENCIES = gcctestdir/ld
large_symbol_alignment_LDFLAGS = -Bgcctestdir/

It leads to

`echo g++ -mx32  -W -Wall    -Werror -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-fmerge-constants -g -O2   -o basic_pic_test | sed -e
's/-Wp,-D_FORTIFY_SOURCE=[0-9][0-9]*//'` -Bgcctestdir/ basic_pic_test.o
g++: error: libgoldtest.a: No such file or directory
make[6]: *** [large_symbol_alignment] Error 1

with "make -j 8 check".

Also

icf_test icf_test.map: icf_test.o gcctestdir/ld
        $(CXXLINK) -o icf_test -Bgcctestdir/ -Wl,--icf=all,-Map,icf_test.map
icf_test.o

icf_safe_test icf_safe_test.map: icf_safe_test.o gcctestdir/ld
        $(CXXLINK) -o icf_safe_test -Bgcctestdir/
-Wl,--icf=safe,-Map,icf_safe_test.map icf_safe_test.o

icf_safe_so_test icf_safe_so_test.map: icf_safe_so_test.o gcctestdir/ld
        $(CXXLINK) -o icf_safe_so_test -Bgcctestdir/
-Wl,--icf=safe,-Map,icf_safe_so_test.map icf_safe_so_test.o -fPIC -shared

aren't safe with "make -j8 check".  They lead to

`echo g++ -mx32  -W -Wall    -Werror -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-fmerge-constants -g -O2   -o icf_safe_test | sed -e
's/-Wp,-D_FORTIFY_SOURCE=[0-9][0-9]*//'` -o icf_safe_test -Bgcctestdir/
-Wl,--icf=safe,-Map,icf_safe_test.map icf_safe_test.o
`echo g++ -mx32  -W -Wall    -Werror -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-fmerge-constants -g -O2   -o icf_safe_test.map | sed -e
's/-Wp,-D_FORTIFY_SOURCE=[0-9][0-9]*//'` -o icf_safe_test -Bgcctestdir/
-Wl,--icf=safe,-Map,icf_safe_test.map icf_safe_test.o
`echo g++ -mx32  -W -Wall    -Werror -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-fmerge-constants -g -O2   -o icf_safe_so_test | sed -e
's/-Wp,-D_FORTIFY_SOURCE=[0-9][0-9]*//'` -o icf_safe_so_test -Bgcctestdir/
-Wl,--icf=safe,-Map,icf_safe_so_test.map icf_safe_so_test.o -fPIC -shared
collect2: error: ld terminated with signal 7 [Bus error]
make[7]: *** [icf_safe_test] Error 1

-- 
You are receiving this mail because:
You are on the CC list for the bug.