[Bug binutils/22245] Potential UB in bfd_set_error

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=22245

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The master branch has been updated by Alan Modra <address@hidden>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2ca7de3746be7484aa5affceafa1ad2e1d789381

commit 2ca7de3746be7484aa5affceafa1ad2e1d789381
Author: Pedro Alves <address@hidden>
Date:   Wed Oct 4 14:20:51 2017 +0100

    bfd_set_input_error

    A downside to the 2017-10-04 PR22245 fix is that bfd_set_error can now
    silently accept invalid errors if/when someone passes the a value of
    the wrong enumeration type, which previously would be caught by the
    -Wenum-conversion warning.

        PR 22245
        * bfd.c (bfd_set_error): Revert 2017-10-04 change.  Remove
        ellipsis parameter.  Split out bfd_error_on_input code to..
        (bfd_set_input_error): .. New function.
        * archive.c (_bfd_write_archive_contents): Use bfd_set_input_error.
        * vms-lib.c (_bfd_vms_lib_write_archive_contents): Likewise.
        * bfd-in2.h: Regenerate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.