[Bug gold/23455] gold: should the discarded version information warning exist?

[ccoutant at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23455

Cary Coutant <ccoutant at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Cary Coutant <ccoutant at gmail dot com> ---
It's still really dangerous to discard the version information.
If the symbol ends up being called, the loader will most likely
bind the call to the base version, and unpredictable things may
happen. In cases where the symbol is merely a canary, like
pthread_key_create, it shouldn't matter unless the pthreads library
ends up being loaded with the application even though it wasn't
linked in.

I think you should always link -lpthread with --no-as-needed.
The GCC driver ought to be fixed to do this automatically.

I'm really not sure why __cxa_finalize triggered the warning --
why would there be a weak reference to it?

I've disabled the warning by default, and added a --warn-drop-version
option for those who want it.

Fixed on trunk and 2.31 branch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.