bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/23486] GNU_PROPERTY_X86_ISA_1_USED isn't merged properly


From: cvs-commit at gcc dot gnu.org
Subject: [Bug ld/23486] GNU_PROPERTY_X86_ISA_1_USED isn't merged properly
Date: Fri, 10 Aug 2018 18:38:44 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=23486

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The binutils-2_31-branch branch has been updated by H.J. Lu
<address@hidden>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d55c3e36094f06bb1fb02f5eac19fdccf1d91f7e

commit d55c3e36094f06bb1fb02f5eac19fdccf1d91f7e
Author: H.J. Lu <address@hidden>
Date:   Wed Aug 8 06:09:15 2018 -0700

    x86: Properly merge GNU_PROPERTY_X86_ISA_1_USED

    Without the GNU_PROPERTY_X86_ISA_1_USED property, all ISAs may be used.
    If a bit in the GNU_PROPERTY_X86_ISA_1_USED property is unset, the
    corresponding x86 instruction set isn’t used.  When merging properties
    from 2 input files and one input file doesn't have the
    GNU_PROPERTY_X86_ISA_1_USED property, the output file shouldn't have
    it neither.  This patch removes the GNU_PROPERTY_X86_ISA_1_USED
    property if an input file doesn't have it.

    This patch replaces the GNU_PROPERTY_X86_ISA_1_USED property with the
    GNU_PROPERTY_X86_ISA_1_NEEDED property which is the minimum ISA
    requirement.

    bfd/

        PR ld/23486
        * elfxx-x86.c (_bfd_x86_elf_merge_gnu_properties): Remove
        GNU_PROPERTY_X86_ISA_1_USED if an input file doesn't have it.
        (_bfd_x86_elf_link_setup_gnu_properties): Adding the
        GNU_PROPERTY_X86_ISA_1_NEEDED, instead of
        GNU_PROPERTY_X86_ISA_1_USED, property.

    ld/

        PR ld/23486
        * testsuite/ld-i386/i386.exp: Run PR ld/23486 tests.
        * testsuite/ld-x86-64/x86-64.exp: Likewise.
        * testsuite/ld-i386/pr23486a.d: New file.
        * testsuite/ld-i386/pr23486b.d: Likewise.
        * testsuite/ld-x86-64/pr23486a-x32.d: Likewise.
        * testsuite/ld-x86-64/pr23486a.d: Likewise.
        * testsuite/ld-x86-64/pr23486a.s: Likewise.
        * testsuite/ld-x86-64/pr23486b-x32.d: Likewise.
        * testsuite/ld-x86-64/pr23486b.d: Likewise.
        * testsuite/ld-x86-64/pr23486b.s: Likewise.
        * testsuite/ld-i386/property-3.r: Remove "x86 ISA used".
        * testsuite/ld-i386/property-4.r: Likewise.
        * testsuite/ld-i386/property-5.r: Likewise.
        * testsuite/ld-i386/property-x86-ibt3a.d: Likewise.
        * testsuite/ld-i386/property-x86-ibt3b.d: Likewise.
        * testsuite/ld-i386/property-x86-shstk3a.d: Likewise.
        * testsuite/ld-i386/property-x86-shstk3b.d: Likewise.
        * testsuite/ld-x86-64/property-3.r: Likewise.
        * testsuite/ld-x86-64/property-4.r: Likewise.
        * testsuite/ld-x86-64/property-5.r: Likewise.
        * testsuite/ld-x86-64/property-x86-ibt3a-x32.d: Likewise.
        * testsuite/ld-x86-64/property-x86-ibt3a.d: Likewise.
        * testsuite/ld-x86-64/property-x86-ibt3b-x32.d: Likewise.
        * testsuite/ld-x86-64/property-x86-ibt3b.d: Likewise.
        * testsuite/ld-x86-64/property-x86-shstk3a-x32.d: Likewise.
        * testsuite/ld-x86-64/property-x86-shstk3a.d: Likewise.
        * testsuite/ld-x86-64/property-x86-shstk3b-x32.d: Likewise.
        * testsuite/ld-x86-64/property-x86-shstk3b.d: Likewise.

    (cherry picked from commit f7309df20c4e787041cedc4a6aced89c15259e54)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]