[Bug ld/24576] Feature request: error out when passed the same linker script with -T and as an object file

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=24576

--- Comment #3 from Nick Clifton <nickc at redhat dot com> ---
(In reply to Julius Werner from comment #2)

Hi Julius,

> Okay, I looked into it and I think I found a reasonably clean way to do it
> (just checking that no linker script is ever parsed twice, because that just
> wouldn't make sense in any situation). 

Thanks.  I did feel I was being a bit cheeky by asking you to do this,
but it is nice to see that you went ahead anyway! :-)

> However, I'm not quite sure how to
> submit my patch... I can't really find contributing guidelines for binutils
> anywhere. Can you link me to the right place or explain the process?

Sure.  There are some notes in the binutils/MAINTAINERS file, but here is a
quick summary:

  * Patches should be created according to the GNU Coding Standard:
    https://www.gnu.org/prep/standards/

  * They should be submitted to the binutils mailing list for review.
    (address@hidden)

  * They should be tested before hand.  (You would be surprised how
    often this does not appear to happen).

  * For "legally significant" patches a copyright assignment needs to 
    be on file with the FSF before the patch can be accepted.
   
https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html#Legally-Significant

    In order to obtain a copyright assignment, one of these forms
    needs to be completed and sent to the FSF:
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=tree;f=doc/Copyright;h=22db9a802b4da96ad455cd933351c1359108f95d;hb=HEAD

I assume that you are familiar with the concept of patch review
and resubmission, so I will not go into that.


> Attaching the patch here for lack of a better way to submit it.

Which is fine in this case.  I do not see a copyright assignment on file
for you or Chromium, but I think that in this particular case it is safe
to consider the patch as not being legally significant.  So I have gone
ahead and tested your patch, found no problems and applied it to the sources.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.