bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/25665] aarch64 veneers not inserted with large .text object betw


From: wdijkstr at arm dot com
Subject: [Bug ld/25665] aarch64 veneers not inserted with large .text object between caller and target
Date: Wed, 22 Apr 2020 20:04:00 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=25665

--- Comment #14 from Wilco <wdijkstr at arm dot com> ---
So the bug is this in bfd/elfnn-aarch64.c (group_sections, #3609):

          /* But wait, there's more!  Input sections up to stub_group_size
             bytes before the stub section can be handled by it too.  */
          if (!stubs_always_before_branch)
            {
              total = 0;  --------------> BUG should be tail->size
              while (prev != NULL
                     && ((total += tail->output_offset - prev->output_offset)
                         < stub_group_size))

We're placing a stub section after tail, so we must reach from the start of the
previous section to the end of tail, not just to the start!

The Arm version of this function does this correctly - given it is much better
written, copying that is the best option.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]