[Bug binutils/29483] abort at i386-dis.c:9289

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29483

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The master branch has been updated by Jan Beulich <jbeulich@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ac3fe48fd61a92d03c66152038df4fc184bf5fcd

commit ac3fe48fd61a92d03c66152038df4fc184bf5fcd
Author: Jan Beulich <jbeulich@suse.com>
Date:   Mon Sep 12 08:19:55 2022 +0200

    x86: avoid i386_dis_printf()'s staging area for a fair part of output

    While PR binutils/29483 has now been addressed differently, this
    originally proposed change still has its merits: Avoiding vsnprintf()
    for typically far more than half of the overall output results in a 2-3%
    performance gain in my testing (with debug builds of objdump, libbfd,
    and libopcodes).

    With that part of output no longer using staging_area[], the array also
    doesn't need to be quite as large anymore (the largest presently used
    size is 27, from "64-bit address is disabled").

    While limiting the scope of "res" it became apparent that
    - no caller cares about the function's return value,
    - the comment about the return value was wrong,
    - a particular positive return value would have been meaningless to the
      caller.
    Therefore convert the function to return "void" at the same time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.