[Bug binutils/32154] New: Binutils: libiberty: WINAPI functions used with chars instead of trivial chars.

[carlo.bramix at libero dot it]

https://sourceware.org/bugzilla/show_bug.cgi?id=32154

            Bug ID: 32154
           Summary: Binutils: libiberty: WINAPI functions used with chars
                    instead of trivial chars.
           Product: binutils
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: binutils
          Assignee: unassigned at sourceware dot org
          Reporter: carlo.bramix at libero dot it
  Target Milestone: ---

While doing my test with the experimental support for aarch64-w64-ming32, I
found few mistakes into libiberty, when the environment is configured as
UNICODE.
The problems come out because because some Windows API functions are called
with plain chars strings, while they should be trivial chars.
Hopefully, the fix is very simple to do.
In other words, something like:

conout_handle = CreateFile("CONOUT$",

must be replaced with:

conout_handle = CreateFile(TEXT("CONOUT$"),

so that it can work when CreateFile() is set to CreateFileW() rather than
CreateFileA() and viceversa.
Hopefully, there are just few points laking this.

Attached patch fixes these mistakes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.