[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Changes in readpipe.c for bison-1.75(WIN32)

From: Paul Eggert
Subject: Re: Changes in readpipe.c for bison-1.75(WIN32)
Date: Tue, 5 Nov 2002 12:19:55 -0800 (PST)

> From: "=?ks_c_5601-1987?B?udqxzcXCXChHdWktVGFpIFBhcmtcKQ==?=" <address@hidden>
> Date: Tue, 5 Nov 2002 22:50:59 +0900

> I have ported bison-1.75 on WIN32 platform.

Thanks, but after Bison 1.75 was released we removed readpipe.c and
implemented the subsidiary process in a different way, so your fix no
longer applies to Bison.  I have no idea whether the new code runs on
Microsoft operating systems, but you can find a more recent test
version at:


> #ifdef WIN32                        /* ++tai */
>     /* Create the pipe */
>     if(_pipe(fds, PIPE_BUFFER_SIZE, _O_BINARY | _O_NOINHERIT) =3D=3D -1)
>         return 0;
>     /* Duplicate stdout handle */
>     if((hStdOut =3D _dup(_fileno(stdout))) =3D=3D -1)
>               return 0;
> ...

We'd prefer a patch that does not clutter the main source code.
Please see <ftp://ftp.gnu.org/gnu/diffutils/diffutils-2.8.1.tar.gz>
for an example of how to do that.  The Microsoft-related code is in an
"ms" subdirectory, and there is no Microsoft-specific ifdef anywhere
in the mainline diffutils code.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]