Re: webkit will not build with bison 2.4

[Joel E. Denny]

On Wed, 19 Nov 2008, George Sherwood wrote:

> Thanks for the hint and I tried follow the above, but it didn't work.
> It did get past the initial call but something must not have been
> correct, because it failed on the compile of the derived file.
> 
> SSGrammar.Tpo -c -o DerivedSources/libWebCore_la-CSSGrammar.lo `test -f 
> 'DerivedSources/CSSGrammar.cpp' || echo
> './'`DerivedSources/CSSGrammar.cpp WebCore/css/CSSGrammar.y: In
> function ???int cssyyparse(void*)???: WebCore/css/CSSGrammar.y:1353: error:
> expected `;' before ???}??? token WebCore/css/CSSGrammar.y:1354: error:
> expected `;' before ???}??? token WebCore/css/CSSGrammar.y:1356: error:
> expected `;' before ???}??? token make[1]: ***
> [DerivedSources/libWebCore_la-CSSGrammar.lo] Error 1 make[1]: Leaving
> directory `/usr/src/WebKit-r38592' make: *** [all] Error 2

I can't tell for sure without seeing the grammar file, but it looks like 
you've encountered another change in Bison 2.4.  That is, previous 
versions of Bison appended semicolons to semantic actions so that users 
could omit the final semicolons and still get the generated code to 
compile.  This was an undocumented and useless feature, and we have 
discussed removing it intentionally in future releases.  However, we 
didn't mean to remove it in Bison 2.4 and are adding it back for 2.4.1.  
Anyway, as long as the webkit developers are fixing things, they might as 
well add the final semicolons to their semantic actions.