[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/11] quote consistently and make tests pass with new quotin

From: Akim Demaille
Subject: Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib
Date: Fri, 17 Feb 2012 09:39:16 +0100

Le 17 févr. 2012 à 09:29, Paul Eggert a écrit :

> On 02/16/2012 08:20 AM, Akim Demaille wrote:
>> we have an expectation mismatch: quotearg is designed
>> with literal_quoting_style as default style, but
>> quote expects locale_quoting_style as default.
> I wouldn't object to merging the quotearg and quote
> modules; the fact that there are two modules is more
> of a historical accident than anything else.  And this
> might remove the need for the malloc and/or the
> expectation mismatch.  (Sorry, I still don't understand
> the underlying problem well.)

by default:
quote:    locale_quoting_style
quotearg: literal_quoting_style

So as of today they are independent, and merging them into
a single thing might surprise users of either module.  So
if we keep two different styles, the difficulty comes from the
fact that quoting_option, which is richer than quoting_style,
is well hidden in quotearg.c and harder to use (the API is
poorer than that of quoting_style).  Indeed, merging quote
into quotearg would solve many problems.  Yet there would
remain the question: should quotearg and quote use the same
default style?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]