bug-bison
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/11] quote consistently and make tests pass with new quotin


From: Akim Demaille
Subject: Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib
Date: Tue, 6 Mar 2012 23:28:03 +0100

Le 6 mars 2012 à 23:01, Paul Eggert a écrit :

> On 03/06/2012 12:33 AM, Akim Demaille wrote:
>> I've made the changes you asked for, but I can't push
>> into gnulib.  Thanks!
> 
> I looked at it one more time and have a few more (I hope minor)
> suggestions: use the same comment style as the rest of the code,
> avoid the need for quote_quoting_options_, add a ChangeLog entry
> with style similar to gnulib's.
> 
> I think the only change relevant to Bison is you need to put in
> an "&" before quote_quoting_options.  If that's too much of a
> pain we can declare it as an array of size 1 instead, which removes
> the need for "&", though it makes the decl a bit trickier.
> 
> Proposed revised patch attached.

All this is perfect with me!  Thanks for the work.

Bison can live with an additional &.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]