[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] master: Doxygen generation broken

From: Stefano Lattarini
Subject: Re: [PATCH] master: Doxygen generation broken
Date: Wed, 28 Mar 2012 09:33:43 +0200

Hi Tim.  Just a minor nit w.r.t. make portability ...

> --- a/doc/local.mk
> +++ b/doc/local.mk
> @@ -124,7 +124,7 @@ DOXYGEN = doxygen
>  doc: html
>  html-local: doc/Doxyfile
> -     $(AM_V_GEN) cd doc && $(DOXYGEN)
> +     $(AM_V_GEN) $(DOXYGEN) $<
My understanding is that currently the bison build system strives to
be portable to non-GNU make implementations as well, in which case the
'$<' automatic variable should be considered unusable outside suffix
rules; you should spell out the target name explicitly.

And now that I look, I see some other pre-existing dubious usages of
'$<' in the bison makefiles:

  examples/calc++/local.mk:     $(AM_V_at)$(YACCCOMPILE) -o $*.cc $<
  doc/local.mk: $(AM_V_GEN)$< --version >doc/bison.help.t
  doc/local.mk: $(AM_V_at)$< --help   >>doc/bison.help.t
  tests/local.mk:## Leave testsuite.at first for the "testsuite" rule's $<.
  tests/local.mk:       $(AM_V_GEN)$(AUTOTEST) $(AUTOTESTFLAGS) $< -o 


reply via email to

[Prev in Thread] Current Thread [Next in Thread]