[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] maint: simplify parse-gram.y
From: |
Jim Meyering |
Subject: |
Re: [PATCH 2/3] maint: simplify parse-gram.y |
Date: |
Sun, 06 May 2012 11:27:33 +0200 |
Akim Demaille wrote:
> Le 6 mai 2012 à 09:31, Jim Meyering a écrit :
>
>> Pushed.
>
> FTR, I have installed this. Your regen step did not
> use xmemdup0 for some reason, so the generated code
> works, but breaks on the next regeneration.
Ahh... my bad. I merely rebased the 2nd of those 3 commits.
I should have manually ensured that those files were regenerated.
I'm not used to having generated files under version control.
IMHO, the fact that I ran "make distcheck" (and it did not
regenerate those .[ch] files) means that there is room for
improvement.
What do you think about making "make distcheck" ensure that using
the just-built bison induces no significant change in parse-gram.c?
- nuke strncpy, Jim Meyering, 2012/05/03
- [PATCH 1/3] maint: s/strncpy/memcpy/, when equivalent, Jim Meyering, 2012/05/03
- [PATCH 3/3] maint: regen src/parse-gram.[ch], Jim Meyering, 2012/05/03
- [PATCH 2/3] maint: simplify parse-gram.y, Jim Meyering, 2012/05/03
- Re: [PATCH 2/3] maint: simplify parse-gram.y, Akim Demaille, 2012/05/04
- Re: [PATCH 2/3] maint: simplify parse-gram.y, Jim Meyering, 2012/05/04
- Re: [PATCH 2/3] maint: simplify parse-gram.y, Jim Meyering, 2012/05/05
- Re: [PATCH 2/3] maint: simplify parse-gram.y, Akim Demaille, 2012/05/06
- Re: [PATCH 2/3] maint: simplify parse-gram.y, Jim Meyering, 2012/05/06
- Re: [PATCH 2/3] maint: simplify parse-gram.y, Akim Demaille, 2012/05/06
- Re: [PATCH 2/3] maint: simplify parse-gram.y,
Jim Meyering <=
- Re: [PATCH 2/3] maint: simplify parse-gram.y, Akim Demaille, 2012/05/09