[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

build failure

From: Eric Blake
Subject: build failure
Date: Sat, 01 Sep 2012 09:38:23 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0

I got the following error while building the latest master branch of

  CC     src/bison-parse-gram.o
src/parse-gram.y: In function 'add_param':
src/parse-gram.y:779:5: error: implicit declaration of function
'isspace' [-Werror=implicit-function-declaration]

This patch fixes it for me, but I don't know if you instead want to
patch system.h:

diff --git i/src/parse-gram.y w/src/parse-gram.y
index fbb9b54..8f56188 100644
--- i/src/parse-gram.y
+++ w/src/parse-gram.y
@@ -19,6 +19,7 @@

 #include <config.h>
 #include "system.h"
+#include <ctype.h>

 #include "complain.h"
 #include "conflicts.h"

I didn't check what other branches are active, to see if they also need
the patch.  But while looking at system.h, I did notice one other thing;
it has:

# include <sys/types.h>

But because bison uses gnulib, we are guaranteed that:
1. <sys/types.h> always exists, so the use of HAVE_SYS_TYPES_H is pointless
2. these days, POSIX 2008 requires that most headers be self-contained
(that is, you need not include <sys/types.h> prior to another header,
but just use the other header, and the types you need will still be
declared); gnulib enforces this rule, making it quite portable to
compile without ever explicitly including <sys/types.h>.

That is, I think you could delete those three lines with no ill effects.

Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]