bug-bison
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bison-3.1.90 does not build on linux


From: Akim Demaille
Subject: Re: bison-3.1.90 does not build on linux
Date: Fri, 19 Oct 2018 16:28:23 +0200


> Le 19 oct. 2018 à 06:29, Denis Excoffier <address@hidden> a écrit :
> 
> Hello,
> 
> bison-3.1.90 does not build on (my) linux because (at least) clock_gettime() 
> is not found in any library given.
> 
> It seems that LIB_CLOCK_GETTIME and LIB_GETHRXTIME are both correctly 
> assigned to -lrt but nobody uses these macros.
> 
> Using (in Makefile.in):
> src_bison_LDADD = $(LDADD) $(LIB_CLOCK_GETTIME) $(LIB_GETHRXTIME)
> 
> clears the problem.

Hi Denis,

Thanks for the bug report!  Sorry about that.  I’ll push this.

commit f4bcaa241de976e329821796e78d5670511279a8
Author: Akim Demaille <address@hidden>
Date:   Fri Oct 19 16:10:49 2018 +0200

    build: add missing gnulib libs
    
    Reported by Denis Excoffier.
    
    * lib/local.mk, src/local.mk: here.

diff --git a/THANKS b/THANKS
index 7971a0c7..3437e808 100644
--- a/THANKS
+++ b/THANKS
@@ -42,6 +42,7 @@ David J. MacKenzie        address@hidden
 David Kastrup             address@hidden
 David Michael             address@hidden
 Dengke Du                 address@hidden
+Denis Excoffier           address@hidden
 Dennis Clarke             address@hidden
 Derek Clegg               address@hidden
 Derek M. Jones            address@hidden
diff --git a/lib/local.mk b/lib/local.mk
index bf8f6f90..977afb57 100644
--- a/lib/local.mk
+++ b/lib/local.mk
@@ -46,9 +46,18 @@ lib_libbison_a_SOURCES +=                       \
   lib/path-join.h                               \
   lib/path-join.c
 
+lib_libbison_a_LIBADD +=                        \
+  $(ISNAND_LIBM)                                \
+  $(ISNANF_LIBM)                                \
+  $(ISNANL_LIBM)                                \
+  $(LDEXPL_LIBM)                                \
+  $(LDEXP_LIBM)                                 \
+  $(LIB_CLOCK_GETTIME)                          \
+  $(LIB_GETHRXTIME)
+
 # The Yacc compatibility library.
 if ENABLE_YACC
-lib_LIBRARIES = lib/liby.a
-EXTRA_LIBRARIES = lib/liby.a
-lib_liby_a_SOURCES = lib/main.c lib/yyerror.c
+  lib_LIBRARIES = lib/liby.a
+  EXTRA_LIBRARIES = lib/liby.a
+  lib_liby_a_SOURCES = lib/main.c lib/yyerror.c
 endif
diff --git a/src/local.mk b/src/local.mk
index f1384c0c..a41a5f39 100644
--- a/src/local.mk
+++ b/src/local.mk
@@ -13,16 +13,6 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-LDADD =                                         \
-  $(ISNAND_LIBM)                                \
-  $(ISNANF_LIBM)                                \
-  $(ISNANL_LIBM)                                \
-  $(LDEXPL_LIBM)                                \
-  $(LDEXP_LIBM)                                 \
-  $(LIBINTL)                                    \
-  $(LIBTHREAD)                                  \
-  lib/libbison.a
-
 bin_PROGRAMS = src/bison
 # Prettify Automake-computed names of compiled objects.
 src_bison_SHORTNAME = bison
@@ -114,13 +104,20 @@ BUILT_SOURCES +=                                \
   src/scan-gram.c                               \
   src/scan-skel.c
 
+src_bison_LDADD =                               \
+  $(LIBINTL)                                    \
+  $(LIBTHREAD)                                  \
+  lib/libbison.a
+
+
+
 
 ## ------ ##
 ## yacc.  ##
 ## ------ ##
 
 if ENABLE_YACC
-bin_SCRIPTS = src/yacc
+  bin_SCRIPTS = src/yacc
 endif
 EXTRA_SCRIPTS = src/yacc
 MOSTLYCLEANFILES += src/yacc




reply via email to

[Prev in Thread] Current Thread [Next in Thread]