RE: bison-3.2 build feedback

[Simon Fenney]

Thanks! 

Guess there's another thing to add to my growing "to do" list   :-/

Sorry for causing you bother.

Simon

-----Original Message-----
From: Akim Demaille [mailto:address@hidden 
Sent: 04 November 2018 12:20
To: Simon Fenney
Cc: Bison Bugs


Subject: Re: bison-3.2 build feedback

Hi Simon,

> Le 31 oct. 2018 à 14:43, Simon Fenney <address@hidden> a écrit :
> 
> Dear Akim,
>  
> I, too, ran into the “-lrt” on the “ar” build command with the 3.2 release on 
> a Centos(?) machine (2.6.32-696.3.2.el6.x86_64 ) using gcc 6.4.0
> Although version 3.2.5-bd7ae fixes the –lrt  problem (many thanks, BTW), I 
> saw  Kiyoshi KANAZAWA’s post 
> (https://lists.gnu.org/archive/html/bison-patches/2018-10/msg00152.html) so 
> also tried “make check”.   I got the following two errors in the “C++ 
> Features” batch:
> 468: Doxygen Public Documentation                    FAILED (c++.at:750)
> 469: Doxygen Private Documentation                   FAILED (c++.at:751)
> I’ve attached a tarball of the test log directories, if that’s any help.
> I’ve no idea how critical these errors actually are.
> Best regards

Your logs:

#                             -*- compilation -*-
468. c++.at:750: testing Doxygen Public Documentation ...
./c++.at:750: bison -fno-caret -o input.cc input.yy
./c++.at:750: doxygen --version || exit 77
stdout:
1.8.12
./c++.at:750: doxygen
stderr:
/projects/research/tools/SrcDirs/BuildingOK/bison/bison-3.2.3-5d07f/tests/testsuite.dir/468/input.cc:898:
 warning: no matching class member found for
  void yy::parser::error(const std::string &m) Possible candidates:
  virtual void yy::parser::error(const location_type &loc, const std::string 
&msg)
  void yy::parser::error(const syntax_error &err)

AFPL Ghostscript 8.50: Unrecoverable error, exit code 1 AFPL Ghostscript 8.50: 
Unrecoverable error, exit code 1
--- /dev/null   2018-10-13 23:36:07.088999987 +0100
+++ 
/projects/research/tools/SrcDirs/BuildingOK/bison/Current/tests/testsuite.dir/at-groups/468/stdout
  2018-10-31 13:27:23.136220348 +0000
@@ -0,0 +1,18 @@
+Error: /invalidfont in findfont
+Operand stack:
+   boxfont   Times-Roman   Font   Times-Roman   285758   Times-Roman   
--nostringval--   Times-Roman   NimbusRomNo9L-Regu   Courier   NimbusMonL-Regu
+Execution stack:
+   %interp_exit   .runexec2   --nostringval--   --nostringval--   
--nostringval--   2   %stopped_push   --nostringval--   --nostringval--   
--nostringval--   false   1   %stopped_push   1   3   %oparray_pop   1   3   
%oparray_pop   --nostringval--   1   3   %oparray_pop   1   3   %oparray_pop   
.runexec2   --nostringval--   --nostringval--   --nostringval--   2   
%stopped_push   --nostringval--   2   3   %oparray_pop   3   3   %oparray_pop   
--nostringval--   --nostringval--   --nostringval--   --nostringval--   
--nostringval--   false   1   %stopped_push   6   4   %oparray_pop   
--nostringval--   --nostringval--   --nostringval--   1   -1   1   
--nostringval--   %for_neg_int_continue
+Dictionary stack:
+   --dict:1119/1686(ro)(G)--   --dict:0/20(G)--   --dict:88/200(L)--   
--dict:17/17(ro)(G)--   --dict:1119/1686(ro)(G)--
+Current allocation mode is local
+Last OS error: 2
+Error: /invalidfont in findfont
+Operand stack:
+   boxfont   Times-Roman   Font   Times-Roman   285759   Times-Roman   
--nostringval--   Times-Roman   NimbusRomNo9L-Regu   Courier   NimbusMonL-Regu
+Execution stack:
+   %interp_exit   .runexec2   --nostringval--   --nostringval--   
--nostringval--   2   %stopped_push   --nostringval--   --nostringval--   
--nostringval--   false   1   %stopped_push   1   3   %oparray_pop   1   3   
%oparray_pop   --nostringval--   1   3   %oparray_pop   1   3   %oparray_pop   
.runexec2   --nostringval--   --nostringval--   --nostringval--   2   
%stopped_push   --nostringval--   2   3   %oparray_pop   3   3   %oparray_pop   
--nostringval--   --nostringval--   --nostringval--   --nostringval--   
--nostringval--   false   1   %stopped_push   6   4   %oparray_pop   
--nostringval--   --nostringval--   --nostringval--   1   -1   1   
--nostringval--   %for_neg_int_continue
+Dictionary stack:
+   --dict:1119/1686(ro)(G)--   --dict:0/20(G)--   --dict:88/200(L)--   
--dict:17/17(ro)(G)--   --dict:1119/1686(ro)(G)--
+Current allocation mode is local
+Last OS error: 2
468. c++.at:750: 468. Doxygen Public Documentation (c++.at:750): FAILED 
(c++.at:750)

I have addressed the warning part in the appended patch.
The error is due to a problem in your environment.  Ghostscript does not work 
properly, which breaks the generation of the documentation in PDF.

Nothing relevant for Bison here.

commit b7eab01cb5276e87d54bb5d2827b0f197fe76ece
Author: Akim Demaille <address@hidden>
Date:   Sun Nov 4 13:03:43 2018 +0100

    c++: improve the generated documentation
    
    * data/lalr1.cc, data/location.cc: Improve documenting comments.
    * tests/c++.at (Doxygen Documentation): Fix AT_BISON_OPTION_PUSHDEFS,
    so that the generated yyerror is correct.
    * tests/c++.at, tests/headers.at: Prefer %empty.

diff --git a/data/lalr1.cc b/data/lalr1.cc index 30c6f7b9..936dacd1 100644
--- a/data/lalr1.cc
+++ b/data/lalr1.cc
@@ -272,8 +272,9 @@ m4_define([b4_shared_declarations],
     /// Print the state stack on the debug stream.
     virtual void yystack_print_ ();
 
-    // Debugging.
+    /// Debugging level.
     int yydebug_;
+    /// Debug stream.
     std::ostream* yycdebug_;
 
     /// \brief Display a symbol type, value and location.
diff --git a/data/location.cc b/data/location.cc index 88106036..906939d4 100644
--- a/data/location.cc
+++ b/data/location.cc
@@ -59,7 +59,7 @@ m4_ifdef([b4_location_file],  # ------------------  # Define 
the position and location classes.
 m4_define([b4_location_define],
-[[  /// Abstract a position.
+[[  /// A point in a source file.
   class position
   {
   public:]m4_ifdef([b4_location_constructors], [[ @@ -178,7 +178,7 @@ 
m4_define([b4_location_define],
     return ostr << pos.line << '.' << pos.column;
   }
 
-  /// Abstract a location.
+  /// Two points in a source file.
   class location
   {
   public:
diff --git a/tests/c++.at b/tests/c++.at index c25aca32..b23f761b 100644
--- a/tests/c++.at
+++ b/tests/c++.at
@@ -679,14 +679,15 @@ m4_define([AT_CHECK_DOXYGEN],
          [m4_fatal([invalid argument: $1])])  AT_SETUP([Doxygen $1 
Documentation])
 
-AT_BISON_OPTION_PUSHDEFS([%skeleton "lalr1.cc"])
+AT_BISON_OPTION_PUSHDEFS([%skeleton "lalr1.cc" %locations])
 AT_DATA([input.yy],
-[[%skeleton "lalr1.cc"
+[[%require "3.2"
+%skeleton "lalr1.cc"
 %locations
 %defines
 %debug
 %%
-exp: /* empty */;
+exp: %empty;
 %%
 ]AT_YYERROR_DEFINE[
 ]])
diff --git a/tests/headers.at b/tests/headers.at index 490cf1d4..637fd81c 100644
--- a/tests/headers.at
+++ b/tests/headers.at
@@ -41,7 +41,7 @@ AT_DATA_GRAMMAR([$1.y],  ]AT_YYLEX_DECLARE_EXTERN[  %}  %%
-dummy: /* empty */;
+dummy: %empty;
 %%
 #include <$1.h>
 ])
@@ -81,7 +81,7 @@ AT_DATA_GRAMMAR([input.y],  ]AT_YYLEX_DEFINE[  %}  %%
-exp: /* empty */;
+exp: %empty;
 ]])
 
 AT_BISON_CHECK([--defines -o input.c input.y])