[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] test: report.at: avoid tiny new failure

From: Akim Demaille
Subject: Re: [PATCH] test: report.at: avoid tiny new failure
Date: Sun, 19 Jan 2020 10:07:47 +0100

Hi Jim,

> Le 19 janv. 2020 à 05:55, Jim Meyering <address@hidden> a écrit :
> Hi Akim et al,
> I tested latest bison from git and found only one tiny test failure:
> @@ -1,6 +1,6 @@
> // Generated by GNU Bison VERSION.
> // Report bugs to <address@hidden>.
> -// Home page: <http://www.gnu.org/software/bison/>.
> +// Home page: <https://www.gnu.org/software/bison/>.

Thanks for the report!  But I guess you are using a non-released version
of Autoconf that changed the default URL: I cannot reproduce this failure
and the CI is green. (OMG, Autoconf 2.69 was released in 2012!!!).

I guess the full fix is as follows.  Installed in maint, will be merged
into master.

(Why do we promote https https?  What do we actually gain?  I can see
it make machines work more and waste more electricity which is quite at
odds with trying to be kind to the planet.  So I guess there must be some
real added value, but which one?)


commit 27e822abfd0b336bf7ebbbb97b46e47752ca4663
Author: Jim Meyering <address@hidden>
Date:   Sat Jan 18 20:52:21 2020 -0800

    test: report.at: avoid tiny new failure
    Be robust to newer versions of Autoconf where the package URL defaults
    to https instead of http.
    * configure.ac (AC_INIT): Use https.
    * tests/report.at: Adjust expected output s/http/https/
    to match updated URL.

diff --git a/configure.ac b/configure.ac
index 235e7cc9..3f144cbc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -26,7 +26,9 @@ m4_pattern_allow([^BISON_USE_NLS$])
 AC_INIT([GNU Bison],
         m4_esyscmd([build-aux/git-version-gen .tarball-version]),
-        [address@hidden])
+        [address@hidden],
+        [],
+        [https://www.gnu.org/software/bison/])
                    [The copyright year for this package])
diff --git a/tests/report.at b/tests/report.at
index 1dfa6a3b..8d5ceafc 100644
--- a/tests/report.at
+++ b/tests/report.at
@@ -579,7 +579,7 @@ State 19
 AT_CHECK([sed -e '1s/GNU Bison .*\.$/GNU Bison VERSION./' input.gv], [],
 [[// Generated by GNU Bison VERSION.
 // Report bugs to <address@hidden>.
-// Home page: <http://www.gnu.org/software/bison/>.
+// Home page: <https://www.gnu.org/software/bison/>.
 digraph "input.yy"
@@ -673,7 +673,7 @@ digraph "input.yy"
 AT_CHECK([[sed -e 's/bison-xml-report version="[^"]*"/bison-xml-report 
version="VERSION"/g' input.xml]], [],
 [[<?xml version="1.0"?>
-<bison-xml-report version="VERSION" bug-report="address@hidden" 
+<bison-xml-report version="VERSION" bug-report="address@hidden" 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]