bug-bison
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bison 3.5.92 released [beta]


From: Akim Demaille
Subject: Re: Bison 3.5.92 released [beta]
Date: Sun, 3 May 2020 17:54:40 +0200


> Le 3 mai 2020 à 17:31, Jannick <address@hidden> a écrit :
> 
> Hi Akim,
> 
> On Sun, 3 May 2020 13:18:04 +0200, Akim Demaille wrote:
> 
>> This is the third beta of Bison 3.6.  A few portability issues were
> addressed.
> 
> Please see the test log attached on Windows10/MSYS2 with 3 failing tests.
> It might well be that the failures are caused by end-of-line differences (CR
> vs CRLF), but I could be wrong here.

Thanks for the report!

This should take care of it.

commit df752784c26154df83d17f4848823e2112e6a4be
Author: Akim Demaille <address@hidden>
Date:   Sun May 3 17:44:21 2020 +0200

    examples: beware of portability issues with cmp
    
    As someone wrote nearly 20 years ago in Autoconf's documentation,
    don't use cmp to compare text files, but diff.
    
https://git.savannah.gnu.org/cgit/autoconf.git/commit/?id=abad4f0576a7dc361e5385e19c7681449103cdb1
    Reported by Jannick.
    
    * examples/test: Use diff, not cmp.

diff --git a/examples/test b/examples/test
index a1242e3a..02e59b3f 100755
--- a/examples/test
+++ b/examples/test
@@ -115,7 +115,7 @@ run ()
   } >eff
 
   if test $sta_eff -eq $sta_exp; then
-    if cmp eff exp 2>/dev/null; then
+    if diff eff exp >/dev/null 2>&1; then
       echo "$me: PASS: $number"
     else
       echo "$me: FAIL: $number"




reply via email to

[Prev in Thread] Current Thread [Next in Thread]