[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Why does bison link with readline?
From: |
Akim Demaille |
Subject: |
Re: Why does bison link with readline? |
Date: |
Tue, 13 Oct 2020 12:40:49 +0200 |
Hi Paul,
> Le 12 oct. 2020 à 18:21, Paul Smith <psmith@gnu.org> a écrit :
>
> On Mon, 2020-10-12 at 12:10 -0400, Paul Smith wrote:
>> Is there a reason that bison has -lreadline to the link line? I
>> cannot find any code anywhere in the bison program that invokes
>> readline() or tests any preprocessor option specifying whether
>> readline is linked.
No, you are right, it's completely useless. I stupidly copied-pasted
the list of libraries to link against that gnulib-tool reported, and
I did not pay attention that readline was in there.
> Making this change still allowed bison to link and run correctly for
> me:
>
> --- a/src/local.mk 2020-08-03 10:36:58.000000000 -0400
> +++ b/src/local.mk 2020-10-12 12:14:17.668301244 -0400
> @@ -143,7 +143,6 @@
> $(LIB_SETLOCALE_NULL) \
> $(LIBICONV) \
> $(LIBINTL) \
> - $(LIBREADLINE) \
> $(LIBTEXTSTYLE)
I've installed this as follows in the maint branch. And I've released
3.7.3 just now. Sorry for the trouble!
Cheers!
commit bc5e4541dab3c7be22574d398a295dd94632614f
Author: Akim Demaille <akim.demaille@gmail.com>
Date: Tue Oct 13 06:56:01 2020 +0200
build: don't link bison against libreadline
Reported by Paul Smith <psmith@gnu.org>.
https://lists.gnu.org/r/bug-bison/2020-10/msg00001.html
* src/local.mk (src_bison_LDADD): here.
diff --git a/NEWS b/NEWS
index a10af6f7..7af5b8dc 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,13 @@ GNU Bison NEWS
* Noteworthy changes in release ?.? (????-??-??) [?]
+** Bug fixes
+
+ Fix concurrent build issues.
+
+ The bison executable is no longer linked uselessly against libreadline.
+
+ Fix incorrect use of yytname in glr.cc.
* Noteworthy changes in release 3.7.2 (2020-09-05) [stable]
diff --git a/src/local.mk b/src/local.mk
index 76808906..32d09d10 100644
--- a/src/local.mk
+++ b/src/local.mk
@@ -143,7 +143,6 @@ src_bison_LDADD = \
$(LIB_SETLOCALE_NULL) \
$(LIBICONV) \
$(LIBINTL) \
- $(LIBREADLINE) \
$(LIBTEXTSTYLE)