[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

editfiles Inform bug

From: Robert Shaw
Subject: editfiles Inform bug
Date: Wed, 07 Feb 2001 11:17:16 -0700


There's a bug in the editfiles code that prevents the use of the
"Inform" option. Currently (in version 1.6.2) if you add the "Inform"
option to an editfiles section, you get the following error:

cfengine:arizona2: Unknown action in editing of file /etc/defaultrouter

I looked at the code, and determined the following patch to fix it:

--- cfengine-1.6.2.orig/src/edittools.c Mon Jan  1 10:38:32 2001
+++ cfengine-1.6.2/src/edittools.c      Tue Feb  6 14:59:25 2001
@@ -417,6 +417,7 @@
       case NoEdit:
+      case EditInform:
       case EditUmask:
       case AutoCreate:

Basically, you weren't ignoring the flag later when processing the
actual editing actions, but you already had processed the entry
previously and adjusted the output correctly. With this patch, the
option works as expected.

Please incorporate this fix in the next release if possible.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]