Re: SetCommentStart and SetCommentEnd in Cfengine 1.6.2

[Mark . Burgess]

On 28 Aug, Norbert Gövert wrote:
> Dear Cfengine Maintainers,
> 
> we're using the Debian cfengine package for administration of our
> Linux machines. After migration to Debian woody we got cfengine 1.6.2
> and encoutered some problems with the SetCommentStart and
> SetCommentEnd directives in the editfiles section. Assume the
> following config:
> 
> ,-----
> | control:
> | 
> |   actionsequence  = ( editfiles )
> |     
> | editfiles:
> | 
> |   { /home-local/goevert/tmp/testcf
> |     SetCommentStart "# "
> |     CommentLinesStarting "ToComment"
> |   }
> `-----
> 
> and the contents of /home-local/goevert/tmp/testcf being the single
> line
> 
> ,-----
> | ToComment
> `-----
> 
> After running the configuration nothing happens to file testcf:
> 
> ,-----
> | address@hidden cfengine -f ./cfengine.conf -v
> | [...]
> | ---------------------------------------------------------------------
> | Editing files
> | ---------------------------------------------------------------------
> |
> | cfengine:lucy: Begin editing /home-local/goevert/tmp/testcf
> | cfengine:lucy: End editing /home-local/goevert/tmp/testcf
> | [...]
> | address@hidden cat testcf
> | ToComment
> `-----
> 
> The problem occurs with any setting for SetCommentStart we tested.
> 
> Removing the SetCommentStart line from the configuration yields the
> correct results:
> 
> ,-----
> | address@hidden cfengine -f ./cfengine.conf -v
> | [...]
> | ---------------------------------------------------------------------
> | Editing files
> | ---------------------------------------------------------------------
> |
> | cfengine:lucy: Begin editing /home-local/goevert/tmp/testcf
> | Commenting # ToComment
> | cfengine:lucy: End editing /home-local/goevert/tmp/testcf
> | [...]
> | address@hidden cat testcf
> | # ToComment
> `-----
> 
> Another ridiculous effect occurs when using a configuration with
> SetCommentEnd:
> 
> ,-----
> | editfiles:
> | 
> |   { /home-local/goevert/tmp/testcf
> |     SetCommentEnd "#"
> |     CommentLinesStarting "ToComment"
> |   }
> `-----
> 
> ,-----
> | address@hidden cfengine -f ./cfengine.conf -v
> | [...]
> | ---------------------------------------------------------------------
> | Editing files
> | ---------------------------------------------------------------------
> |
> | cfengine:lucy: Begin editing /home-local/goevert/tmp/testcf
> | Commenting # ToCommentToComment
> | cfengine:lucy: End editing /home-local/goevert/tmp/testcf
> | [...]
> | address@hidden cat testcf
> | # ToCommentToComment
> `-----
> 
> With our old cfengine version (from Debian potato, v1.5.3) everything
> worked as expected.
> 
> Can you help? Thanks in advance!
> 
>  Regards, Norbert.
> 


I have tried out all of the above with the current working version
(cfengine 2.0.a13 @ ftp.iu.hio.no/pub/cfengine) and I everything
works perfectly. I am not sure what is going on here. If you
are looking at cfengine for woody now, I would look at 1.6.3 or
this 2.0.a13 alpha version. This version 2 is stable and contains
important changes which will make the future a brighter place!

Mark

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Work: +47 22453272            Email:  address@hidden
Fax : +47 22453205            WWW  :  http://www.iu.hio.no/~mark
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~