Re: Patches for Full Qualified, Mixed Case Hostnames

[Mark . Burgess]

Patched in 2.1.1
M


On 30 Nov, Bob Van Valzah wrote:
> Dear cfengine maintainers,
> 
> I'm attaching three patches that I've found necessary to run cfengine in
> my environment.  Others wouldn't need these patches if they used
> hostnames that were not fully qualified or if they were fully qualified
> but used all lower case.
> 
> I suspect that these patches make cfengine more general and also provide
> a very small speed improvement.  I'm just calling case insensative
> string comparisons whenever domain names are involved.  I'd guess that
> this is a tad faster than malloc()ing space for a lower case version of
> the domain name.
> 
> Before incorporating these patches, you should check to make sure that
> strcasestr() is present on all platforms where strstr() is present. 
> I've only verified it for FreeBSD and Linux (RH 7.3).
> 
> I should also say it's tricky to find out why cfengine doesn't work in
> an environment like mine.  Incorporating these patches into the source
> tree would save others the pain I've felt.
> 
> Line numbers are relative to 2.1.0p1.
> 
> Thanks for your consideration.  And thanks for your work on cfengine!
> 
>       Bob
> 
> 



~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Work: +47 22453272            Email:  address@hidden
Fax : +47 22453205            WWW  :  http://www.iu.hio.no/~mark
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~