[Bug classpath/23916] java.security.AccessControlContext forget Subject in Subject.doAs* methods

[csm at gnu dot org]

------- Additional Comments From csm at gnu dot org  2005-09-23 06:24 -------
This patch looks mostly okay; I'm curious, however, if the domain combiner is 
never null in the passed-
in context.

I do, however, see another bug in our implementation: the AccessControlContext 
constructor is not 
protected by a security check. Without this, this patch would allow arbitrary 
code to specify whatever 
ProtectionDomains they please, if they pass an appropriate DomainCombiner in. 
Also, I think our 
package-private constructor needs to compute:

  (domain-intersection thread-perms (user-domain-combiner thread-perms 
context-perms))

...that is, apply the IntersectingDomainCombiner to the protection domains 
after applying the user-
specified one.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23916