[Bug swing/30337] NPE with own JComboBox if editor nis null

[mark at gcc dot gnu dot org]

------- Comment #1 from mark at gcc dot gnu dot org  2006-12-31 11:51 -------
Is the problem that we are using getEditor() in
BasicComboBoxUI.configureEditor() or shouldn't we be calling configureEditor()
from BasicComboBoxUI.installUI()?

It looks like configureEditor() will be called later anyway whenever the
JComboBox is filled with items anyway. So my proposed patch would be:

diff -u -r1.40 BasicComboBoxUI.java
--- javax/swing/plaf/basic/BasicComboBoxUI.java 24 Jul 2006 15:04:05 -0000    
1.40
+++ javax/swing/plaf/basic/BasicComboBoxUI.java 31 Dec 2006 11:48:35 -0000
@@ -235,8 +235,6 @@
         installListeners();
         if (arrowButton != null)
           configureArrowButton();
-        if (editor != null)
-          configureEditor();
         comboBox.setLayout(createLayoutManager());
         comboBox.setFocusable(true);
         installKeyboardActions();


-- 

mark at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-12-31 11:51:52
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30337