[Bug classpath/33751] Classpath fails to build on Solaris 2.9 (SPARC)

[csm at gnu dot org]

------- Comment #5 from csm at gnu dot org  2008-01-14 19:26 -------
Yeah, just using readdir should work on Darwin, too. The errno stuff is not
broken, the function just needs to return nonzero when the end of directory or
an error is reached.

It would be nice to make this function work with readdir_r, given that
otherwise you'll need to synchronize on a static object.

I'm not sure what you're saying about overflows. Will readdir_r overflow even a
struct dirent that has a d_name of FILENAME_MAX + 1 bytes? The code is using
strncpy, and should use FILENAME_MAX - 1 to ensure that the buffer ends with a
null, but otherwise won't overflow anything. The exploit you linked to seems to
just say "don't use pathconf". I didn't know that some platforms define d_name
to be 1 byte, so that does need to be fixed.

Do we have a dependency on glib now? For all platforms? If not, then no, we
shouldn't use glib.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33751