Re: coreutils-5.0.90 patch 1: build feedback

[Jim Meyering]

"Nelson H. F. Beebe" <address@hidden> wrote:
> I applied the patches to tests/shred/remove, src/nice.c, and
> lib/stdbool_.h in coreutils-5.0.90 and repackaged it as
> coreutils-5.0.90.1, then launched builds on just those platforms where
> build failures had previously occurred.
>
> I still get some failures:
...
> ------------------------------------------------------------------------
> Machinetype:            Intel Pentium III (600 MHz);    OpenBSD 3.2 
> GENERIC#25 i386
> Remote gcc version:     gcc (GCC) 3.3
> Remote g++ version:     g++ (GCC) 3.3
> Configure environment:  CC=gcc CXX=g++ LDFLAGS=-Wl,-rpath,/usr/local/lib
>
> if gcc -DHAVE_CONFIG_H -I. -I. -I..  -I.. -I. -I../lib -I../lib   -g -O2 -MT 
> nice.o -MD -MP -MF ".deps/nice.Tpo" \
>   -c -o nice.o `test -f 'nice.c' || echo './'`nice.c; \
> then mv -f ".deps/nice.Tpo" ".deps/nice.Po"; \
> else rm -f ".deps/nice.Tpo"; exit 1; \
> fi
> In file included from nice.c:29:
> /usr/include/sys/resource.h:60: error: field `ru_utime' has incomplete type
> /usr/include/sys/resource.h:61: error: field `ru_stime' has incomplete type
> make[3]: make[3]: Leaving directory `/local/build/coreutils-5.0.90.1/src'

Hi Nelson,

Thanks again for all your testing!
I've fixed this with the following patch relative to coreutils-5.0.90:

        * src/nice.c [!NICE_PRIORITY]: Include <sys/resource.h> after
        system.h so the types from time.h and sys/time.h are available.
        It appears that this is necessary for OpenBSD, NetBSD, and
        Darwin 6.5 (MacOS 10.2.5).  Reported by Nelson Beebe.

Index: src/nice.c
===================================================================
RCS file: /fetish/cu/src/nice.c,v
retrieving revision 1.67
retrieving revision 1.69
diff -u -p -h -u -r1.67 -r1.69
--- src/nice.c  23 Jul 2003 07:29:54 -0000      1.67
+++ src/nice.c  10 Aug 2003 17:50:11 -0000      1.69
@@ -24,11 +24,15 @@
 
 #include <getopt.h>
 #include <sys/types.h>
+
+#include "system.h"
+
 #ifndef NICE_PRIORITY
+/* Include this after "system.h" so we're sure to have definitions
+   (from time.h or sys/time.h) required for e.g. the ru_utime member.  */
 # include <sys/resource.h>
 #endif
 
-#include "system.h"
 #include "error.h"
 #include "long-options.h"
 #include "posixver.h"